feat(playground): playground uses editor, input rendering #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟢 | Statements | 100% | 0/0 |
| 🟢 | Branches | 100% | 0/0 |
| 🟢 | Functions | 100% | 0/0 |
| 🟢 | Lines | 100% | 0/0 |
Test suite run success
1 tests passing in 1 suite.
Report generated by 🧪jest coverage report action from 0152733
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟢 | Statements | 86.11% | 62/72 |
| 🟡 | Branches | 62.5% | 15/24 |
| 🟢 | Functions | 100% | 10/10 |
| 🟢 | Lines | 86.11% | 62/72 |
Test suite run success
6 tests passing in 1 suite.
Report generated by 🧪jest coverage report action from 0152733
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟢 | Statements | 96.74% (-0.22% 🔻) |
800/827 |
| 🟢 | Branches | 98.17% | 214/218 |
| 🟢 | Functions | 88.07% (-0.71% 🔻) |
192/218 |
| 🟢 | Lines | 96.62% (-0.22% 🔻) |
772/799 |
Show files with reduced coverage 🔻
St.❔ |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| 🔴 | EditorJSModel.ts | 35.9% (-1.94% 🔻) |
0% | 11.54% (-0.96% 🔻) |
35.9% (-1.94% 🔻) |
Test suite run success
404 tests passing in 24 suites.
Report generated by 🧪jest coverage report action from 0152733
|
⏭️ No files to mutate for |
|
⏭️ No files to mutate for |
gohabereg
approved these changes
Aug 30, 2024
e11sy
reviewed
Aug 30, 2024
Comment on lines
112
to
114
| if (inputTextNode === null) { | ||
| throw new Error('FormattingAdapter: input element should contain text node'); | ||
| } |
There was a problem hiding this comment.
pass checked text node to avoid this error catching
| @@ -191,6 +191,19 @@ export class BlockNode extends EventBus { | |||
| node.update(value); | |||
| } | |||
|
|
|||
| /** | |||
| * Returns a text value of the specified text node | |||
There was a problem hiding this comment.
Node is not specified for this function
packages/playground/src/App.vue
Outdated
| import CaretIndex from '@/components/CaretIndex.vue'; | ||
| import { BlockToolAdapter, CaretAdapter, FormattingAdapter } from '@editorjs/dom-adapters'; | ||
| import { EditorDocument, EditorJSModel, EventType } from '@editorjs/model'; | ||
| // import CaretIndex from '@/components/CaretIndex.vue'; |
e11sy
approved these changes
Aug 30, 2024
| @@ -191,6 +191,19 @@ export class BlockNode extends EventBus { | |||
| node.update(value); | |||
| } | |||
|
|
|||
| /** | |||
| * Returns a text value of the specified data key | |||
There was a problem hiding this comment.
Suggested change
| * Returns a text value of the specified data key | |
| * Returns a text value of the input with specified data key |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
attachInputnow renders input initial content with formattingModel now has
getText(dataKey)method, Used for initial input value fillCore's
prepareTools()now awaited before initializationFormattingAdapter
formatElementContentfixed, previously it was throwing IndexSizeErrorv2-converter now strips tags for
value